add CI test for clang formatting #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
SeverinDiederichs
force-pushed
the
enforce_clang_format
branch
from
c42818b to
7004111
Compare
agheata
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a quick CI test for checking the clang formatting.
I'll expect this to fail because some files are not properly formatted.
Next step will be to format those and then keep them formatted in the future.
After quite some version issues, the AdePT CI now uses clang-format 19.1.7, as this is the latest version available for ubuntu 22.04, which is used by the CI.
Note that the formatting doesn't always agree with 18.1.3 or 18.1.8, therefore an update to 19.1.7 might be required to pass the CI.