refactor: settings to svelte #102
Conversation
- persist settings - preliminary content for switching profiles when editor is invalid
|
Hello, Please review the implementation of the settings with svelte. I simplified the saving process a lot (I didn't use the state object, but I directly mutate the settings instead), but this might also cause performance issues now, so please let me know if you want me to add that. |
|
related to #59 |
|
Long time no see! Great, great, great! It looks like you are more confident in coding! It is a big change, I will take a look, and learn Svelte…… again 😅 |
|
Yes! It's nice to see you still working on this plugin. And yes I finally set out to follow a course in coding, so I'm able to actually understand what I am doing now 🤣🤣. Note that I am using svelte 5 runes mode for the settings (which is often different from "legacy mode"). The svelte docs are up to date, but sometimes discussions of svelte aren't updated yet, so watch out for that. |
|
Ah, also, I'd like to add support for having multiple profiles active at once. I didn't do that yet because I wanted to keep the refactoring as close to what you've done so far. Also, for storing profiles, maybe we can use a Record data structure since that is the shape of objects in json anyways. Let me know what you think! |
Refactor Settings to Svelte