Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segmentation fault on apple silicon chips #1419

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

augustfengd
Copy link
Contributor

Fixes #1172

Description of the Change

I followed the recommendations in #1172 and it seems to work. 😄 I wasn't able to run aptly repo add foobar curl* without a segmentation fault before.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@augustfengd augustfengd changed the title update goleveldb dependency fix segmentation fault on apple silicon chips Jan 10, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.71%. Comparing base (90343b2) to head (c9da748).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
- Coverage   75.03%   74.71%   -0.33%     
==========================================
  Files         158      158              
  Lines       18356    18356              
==========================================
- Hits        13773    13714      -59     
- Misses       3445     3508      +63     
+ Partials     1138     1134       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx self-assigned this Jan 11, 2025
@neolynx neolynx self-requested a review January 11, 2025 09:59
Copy link
Member

@neolynx neolynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

@neolynx neolynx merged commit 851c509 into aptly-dev:master Jan 11, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportChangesFiles test segfaults on linux-arm64 and darwin-arm64
2 participants