Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow snapshotting empty mirrors #1422

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Allow snapshotting empty mirrors #1422

merged 3 commits into from
Jan 13, 2025

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Jan 11, 2025

Fixes #1416

  • allow to create snapshots of empty mirrors

  • add test

  • uploaded relevant test files to repo.aptly.info

@neolynx neolynx self-assigned this Jan 11, 2025
@neolynx neolynx changed the title Revert "fix empty mirror check" Allow snapshotting empty mirrors Jan 11, 2025
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.03%. Comparing base (4076941) to head (9b9894c).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files         158      158           
  Lines       18356    18356           
=======================================
  Hits        13773    13773           
  Misses       3445     3445           
  Partials     1138     1138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neolynx neolynx requested a review from a team January 11, 2025 18:53
@neolynx neolynx force-pushed the fix/empty-mirror-snapshot branch from a7d6122 to 8546cf3 Compare January 11, 2025 19:01
@neolynx neolynx merged commit 666b5c9 into master Jan 13, 2025
46 checks passed
@neolynx neolynx deleted the fix/empty-mirror-snapshot branch January 13, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aptly 1.6.0 - Cannot Create Snapshot on Mirror with no Packages (Example debian-security non-free)
2 participants