Update wallet adapter vue #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildarH
requested review from
0xmaayan,
kaw2k,
hardsetting and
kent-white
as code owners
0xmaayan
reviewed
Sep 5, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@aptos-labs/wallet-adapter-vue", | |||
| "version": "0.2.0", | |||
| "version": "0.2.1", | |||
There was a problem hiding this comment.
since we use changeset, we dont manually increase package versions, but use pnpm run changeset to manage the upgrades
| @@ -38,14 +43,15 @@ export default defineConfig({ | |||
| input: { | |||
| main: resolve(__dirname, "src/index.ts"), | |||
| }, | |||
| external: ["vue"], | |||
| external: ["vue", "@aptos-labs/wallet-adapter-core"], | |||
There was a problem hiding this comment.
According to documentation it excludes vue itself and @aptos-labs/wallet-adapter-core from bundle
# Conflicts: # pnpm-lock.yaml
|
@ildarH |
ildarH
force-pushed
the
feat-wallet-adapter-vue
branch
from
e5b04e5 to
cbf8165
Compare
0xmaayan
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
vite.config.tsin the Vue adapter to reduce the bundle size. Also, bump the@aptos-labs/wallet-adapter-coredependency version.