Suppor transaction input and payload input for signTransaction
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardsetting
force-pushed
the
gabriele/sign_transaction_v1.1
branch
from
8c56f45 to
8f4c0b8
Compare
hardsetting
commented
Sep 6, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@aptos-labs/wallet-standard", | |||
| "description": "Aptos wallet standard", | |||
| "version": "0.1.0", | |||
| "version": "0.2.0", | |||
There was a problem hiding this comment.
Just in case since I changed some types :)
hardsetting
commented
Sep 6, 2024
| export type AptosSignTransactionFeatureV1_1 = { | ||
| [AptosSignTransactionNamespace]: { | ||
| version: '1.1' | ||
| signTransaction: AptosSignTransactionMethod & AptosSignTransactionMethodV1_1 |
There was a problem hiding this comment.
Since this is a minor bump, we should support exactly the same input/output as before, and can add to it.
It works exactly as expected when implementing the interface e.g. when using 1.1 you NEED to specify both interfaces
and eventually, version 2.0 will drop old interfaces
hardsetting
changed the title
signTransactionsignTransaction
0xmaayan
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a PR series to enable transaction input when using
signTransactionsignTransactionaptos-wallet-adapter#414Previously, the only supported input type was an
AnyRawTransactioninstance.The problem with this is that we're requiring the dapp to generate the transaction (and possibly payload) right before calling
signTransaction.This requires async calls which don't play well with certain browsers and popups.