-
Notifications
You must be signed in to change notification settings - Fork 63
fix: pytest-cov and pytest-xdist were put under 'dev' instead of 'test' #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Before the fix locally After the fix locally |
jnwei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! Thanks for the quick fix
I went to check the action log associated with the most recent commit. It look likes no code coverage artifact was generated for this run.
Could you double check the path of the coverage report and see that it matches with the argument provided to the upload action?
|
Agreed, that is a bit fishy – also the term coverage report didn't print anything (odd) |
|
@jnwei this looks good – the manually triggered GH action has the correct artifact https://github.com/aqlaboratory/openfold-3/actions/runs/21168437686#artifacts |
jnwei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for adding this
|
Very happy to – @sdvillal slight duplication with your PR because we added 'pytest-benchmark' but I don't think this will cause a huge amount of pain (you've probably dealt with most conflicts like this already) |
|
I already merged this into the branch, and no worries about conflicts - we do not know when will we merge the big PR and we cannot stop the world until then :-) |
Summary
#90 introduced pytest-cov and pytest-xdist but these were placed under the 'dev' instead of the 'test' dependency group.
Changes
Related Issues
Testing
Other Notes