added possibility to specify webhook port #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added possibility to specify webhook port, because AQUA used earlieir non-standard webhook port - 8443
added possibility to specify webhook port, because AQUA used earlier non-standard webhook port - 8443 get port value from Values.yaml
added possibility to specify webhook port, because AQUA used earlier non-standard webhook port - 8443 set custom port for deployment from Values.yaml. Use named port
added possibility to specify webhook port, because AQUA used earlier non-standard webhook port - 8443 set named port from Deployment in Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i offer to add possibility specify webhook port, because AQUA used earlier non-standard webhook port - 8443
see for example https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/webhook/server.go#L39
there is 9443 default port for webhook.