Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A collection of fixes for rke, fixes #1780 #1792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

A collection of fixes for rke, fixes #1780 #1792

wants to merge 1 commit into from

Conversation

ttousai
Copy link
Contributor

@ttousai ttousai commented Jan 28, 2025

No description provided.

guyjerby
guyjerby reviewed Jan 30, 2025
View reviewed changes
Copy link

@guyjerby guyjerby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ttousai ,
it seems that there is no update of check 4.2.8 for rke-cis-1.23 to skip, can you check?
in addition 1.3.7 - still shows wrong logic - it should be failed since no 127.0.0.1 but it passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyjerby guyjerby guyjerby left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttousai @guyjerby