Revert "perf: benchmark improve sig GetMetadata"

This reverts commit 330a34e.

pkg/signatures/benchmark/benchmark_test.go

@@ -9,7 +9,6 @@ import (
 
 	"github.com/stretchr/testify/require"
 
-	"github.com/aquasecurity/tracee/pkg/events"
 	"github.com/aquasecurity/tracee/pkg/signatures/benchmark/signature/golang"
 	"github.com/aquasecurity/tracee/pkg/signatures/benchmark/signature/rego"
 	"github.com/aquasecurity/tracee/pkg/signatures/engine"
@@ -231,58 +230,6 @@ func BenchmarkEngineWithNSignatures(b *testing.B) {
 	}
 }
 
-func BenchmarkEngineMultipleMethodsGetMetadata(b *testing.B) {
-	benches := []struct {
-		name     string
-		sigFuncs []func() (detect.Signature, error)
-		Enabled  bool
-	}{
-		{
-			name:     "Performance sig GetMetadata() - static",
-			sigFuncs: []func() (detect.Signature, error){golang.NewPerformanceStatic},
-		},
-	}
-
-	for _, bc := range benches {
-		b.Run(bc.name, func(b *testing.B) {
-			var sigs []detect.Signature
-			for _, sig := range bc.sigFuncs {
-				s, _ := sig()
-				sigs = append(sigs, s)
-			}
-
-			for i := 0; i < b.N; i++ {
-				// Produce events without timing it
-				b.StopTimer()
-				inputs := ProduceEventsInMemory(inputEventsCount)
-				output := make(chan *detect.Finding, inputEventsCount*len(sigs))
-
-				config := engine.Config{
-					Signatures:          sigs,
-					Enabled:             true,
-					SigNameToEventID:    allocateEventIdsForSigs(events.StartSignatureID, sigs),
-					ShouldDispatchEvent: func(int32) bool { return true },
-				}
-
-				e, err := engine.NewEngine(config, inputs, output)
-				require.NoError(b, err, "constructing engine")
-
-				err = e.Init()
-				require.NoError(b, err, "initializing engine")
-				b.StartTimer()
-
-				// Start signatures engine and wait until all events are processed
-				e.Start(waitForEventsProcessed(inputs.Tracee))
-
-				b.StopTimer()
-
-				// Set engine to nil to help with garbage collection
-				e = nil
-				runtime.GC()
-			}
-		})
-	}
-}
 func waitForEventsProcessed(eventsCh chan protocol.Event) context.Context {
 	ctx, cancel := context.WithCancel(context.Background())
 	go func() {

pkg/signatures/benchmark/helpers_test.go

@@ -4,10 +4,7 @@ import (
 	_ "embed"
 	"math/rand"
 
-	"github.com/aquasecurity/tracee/pkg/events"
-	"github.com/aquasecurity/tracee/pkg/logger"
 	"github.com/aquasecurity/tracee/pkg/signatures/engine"
-	"github.com/aquasecurity/tracee/types/detect"
 	"github.com/aquasecurity/tracee/types/protocol"
 	"github.com/aquasecurity/tracee/types/trace"
 )
@@ -174,20 +171,3 @@ func ProduceEventsInMemoryRandom(n int, seed ...trace.Event) engine.EventSources
 		Tracee: eventsCh,
 	}
 }
-
-func allocateEventIdsForSigs(startId events.ID, sigs []detect.Signature) map[string]int32 {
-	namesToIds := make(map[string]int32)
-	newEventDefID := startId
-	// First allocate event IDs to all signatures
-	for _, s := range sigs {
-		m, err := s.GetMetadata()
-		if err != nil {
-			logger.Warnw("Failed to allocate id for signature", "error", err)
-			continue
-		}
-
-		namesToIds[m.EventName] = int32(newEventDefID)
-		newEventDefID++
-	}
-	return namesToIds
-}