fix(flags): use scope flag parser for policy

Make PrepareFilterMapsFromPolicies() use parseScopeFlag() instead of parsing the scope flag manually.
aquasecurity · Sep 1, 2023 · b401e2e · b401e2e
1 parent 52065e1
commit b401e2e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 21 deletions.
diff --git a/pkg/cmd/flags/policy.go b/pkg/cmd/flags/policy.go
@@ -47,23 +47,12 @@ func PrepareFilterMapsFromPolicies(policies []v1beta1.PolicyFile) (PolicyScopeMa
 				break
 			}
 
-			var scopeName, operatorAndValues string
-
-			switch s {
-			case "follow", "!container", "container":
-				scopeName = s
-				operatorAndValues = ""
-			default:
-				operatorIdx := strings.IndexAny(s, "=!<>")
-				scopeName = s[:operatorIdx]
-				operatorAndValues = s[operatorIdx:]
+			parsed, err := parseScopeFlag(s)
+			if err != nil {
+				return nil, nil, errfmt.WrapError(err)
 			}
 
-			scopeFlags = append(scopeFlags, scopeFlag{
-				full:              s,
-				scopeName:         scopeName,
-				operatorAndValues: operatorAndValues,
-			})
+			scopeFlags = append(scopeFlags, parsed)
 		}
 
 		policyScopeMap[pIdx] = policyScopes{

diff --git a/pkg/cmd/flags/policy_test.go b/pkg/cmd/flags/policy_test.go
@@ -361,9 +361,9 @@ func TestPrepareFilterMapsFromPolicies(t *testing.T) {
 					policyName: "!container-scope",
 					scopeFlags: []scopeFlag{
 						{
-							full:              "!container",
-							scopeName:         "!container",
-							operatorAndValues: "",
+							full:      "!container",
+							scopeName: "container",
+							operator:  "!",
 						},
 					},
 				},
@@ -617,9 +617,9 @@ func TestPrepareFilterMapsFromPolicies(t *testing.T) {
 							operatorAndValues: "",
 						},
 						{
-							full:              "!container",
-							scopeName:         "!container",
-							operatorAndValues: "",
+							full:      "!container",
+							scopeName: "container",
+							operator:  "!",
 						},
 						{
 							full:              "uid=1000",