fix(pkg/counter): finish making counter atomic (#3276) #3283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last changes renamed Increment/Decrement to Increase/Decrease. This was reverted after discussions.
With this new approach:
NOTE: The issue is now fully fixed...
Originally, the bug was only about reading counter value in parallel to atomic operation (multiple LOAD/STORE simultaneously, and some not protected by atomics).
Previous fix, made by commit 1e54ce2, fixed data race but overflow errors could be reported more than once. It also had atomic operations for each given argument (if multiple arguments).
This version addresses all concerns.
commit: 0b97409 (main), cherry-pick