Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definition proto #3447

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add definition proto #3447

merged 2 commits into from
Sep 7, 2023

Conversation

josedonizetti
Copy link
Contributor

1. Explain what the PR does

This PR is part of the work to support a v1 for GRPC, it adds the EventDefinition proto, and the GetEventDefinition rpc call.

@josedonizetti josedonizetti mentioned this pull request Sep 6, 2023
Merged
@josedonizetti josedonizetti marked this pull request as ready for review September 6, 2023 19:48
yanivagman
yanivagman approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit b0a7b7e into aquasecurity:main Sep 7, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josedonizetti @yanivagman