Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename !container and binary scope filters #3451

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Sep 6, 2023

Close: #3446

815a02d chore(flags): add scope exec/executable option

The exec/executable scope option is the same of bin/binary, but it is
now the default option among the two. The bin/binary option is now
an alias for exec/executable.

9515061 chore(flags)!: rename !container to not-container

BREAKING CHANGE: !container is now not-container

Rename the scope option !container to not-container, eliminating the
need of quoting the scope value.

2. Explain how to test it

sudo ./dist/tracee -p examples/policies

3. Other comments

@yanivagman
Copy link
Collaborator

Looks good, but maybe we should keep the old binary filter as an alias to executable, wdyt?

@geyslan
Copy link
Member Author

geyslan commented Sep 11, 2023

Looks good, but maybe we should keep the old binary filter as an alias to executable, wdyt?

@yanivagman Done.

Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/docs/filters/filtering.md Outdated Show resolved Hide resolved
BREAKING CHANGE: !container is now not-container

Rename the scope option !container to not-container, eliminating the
need of quoting the scope value.
The exec/executable scope option is the same of bin/binary, but it is
now the default option among the two. The bin/binary option is now
an alias for exec/executable.
@geyslan geyslan merged commit 1a6451d into aquasecurity:main Sep 18, 2023
26 checks passed
@geyslan geyslan deleted the 3446-rename-scopes branch September 18, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename !container and binary scope filters
2 participants