Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: running tracee docker container on amd64 and arm64 #3456

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

AnaisUrlichs
Copy link
Contributor

Regarding the issue detailed in #3454

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
@AnaisUrlichs AnaisUrlichs changed the title WIP: documenting current limitations of running tracee docker container #3454 docs: documenting current limitations of running tracee docker container #3454 Sep 12, 2023
@yanivagman yanivagman linked an issue Sep 20, 2023 that may be closed by this pull request
@rafaeldtinoco
Copy link
Contributor

@AnaisUrlichs FYI git log messages:

  1. keep the "imperative" mood (use fix x,y,z and not fixing x,y,z)
  2. use the subject format we have recently adopted if possible

There are tons of git message best practices around there but they are too prolix for me to point you to for simple stuff. So I would recommend your git messages like:

docs(area_being_documented): include tutorial for x
docs(another_area): rewrite paragraph for better understanding
...

If you have any doubts, use "git log" and check the previous commits and they will give you an idea of how to format your git log.

Thank you

Cheers!

@geyslan geyslan changed the title docs: documenting current limitations of running tracee docker container #3454 docs: running tracee docker container on amd64 and arm64 Sep 28, 2023
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Gonna squash and reword commits.

@geyslan geyslan merged commit 24a269f into aquasecurity:main Sep 28, 2023
2 checks passed
@AnaisUrlichs
Copy link
Contributor Author

Made further changes in accordance with the working solution #3537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document ARM64 quickstart
4 participants