-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streams endpoint #3493
Merged
josedonizetti
merged 1 commit into
aquasecurity:main
from
josedonizetti:add-streams-endpoint
Sep 25, 2023
Merged
Add streams endpoint #3493
josedonizetti
merged 1 commit into
aquasecurity:main
from
josedonizetti:add-streams-endpoint
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
add-streams-endpoint
branch
4 times, most recently
from
September 21, 2023 01:09
e849a4e
to
0f6babd
Compare
yanivagman
reviewed
Sep 21, 2023
josedonizetti
force-pushed
the
add-streams-endpoint
branch
9 times, most recently
from
September 21, 2023 18:51
eb0b439
to
1746664
Compare
josedonizetti
force-pushed
the
add-streams-endpoint
branch
3 times, most recently
from
September 21, 2023 22:43
81fd84e
to
0af542e
Compare
josedonizetti
force-pushed
the
add-streams-endpoint
branch
from
September 22, 2023 00:32
0af542e
to
fe3c232
Compare
yanivagman
reviewed
Sep 22, 2023
josedonizetti
force-pushed
the
add-streams-endpoint
branch
from
September 22, 2023 11:40
fe3c232
to
3187468
Compare
yanivagman
reviewed
Sep 22, 2023
yanivagman
reviewed
Sep 22, 2023
yanivagman
reviewed
Sep 22, 2023
josedonizetti
force-pushed
the
add-streams-endpoint
branch
from
September 23, 2023 13:16
3187468
to
3c79a35
Compare
yanivagman
approved these changes
Sep 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This PR adds the stream endpoint to the grpc server, which closes the implementation of the v1beta1 of the grpc API. The user needs pass which policies to create a stream, and optionally he can filter with fields to get as a response with the field mask.
2. Explain how to test it
test streams:
test fieldmask:
3. Other comments