fix(networking): fix net_packet_http errors on empty OK #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The net_packet_http and net_packet_http_response events are failing for empty replies (such as HTTP/1.x 200 OK replies, for example). Ignore if there is some EOF trying to parse response... it usually means there is a single code response with no body.
|
@geyslan this might be something disturbing the HTTP tests (not sure), but definitely something causing error output where it shouldn't. |
geyslan
approved these changes
Oct 2, 2023
There are 3 rets from eventToProtoHTTPResponse. As long as "err" == nil and "h" == nil, there won't be an error afaict. |
rafaeldtinoco
added a commit
that referenced
this pull request
Oct 6, 2023
The net_packet_http and net_packet_http_response events are failing for empty replies (such as HTTP/1.x 200 OK replies, for example). Ignore if there is some EOF trying to parse response... it usually means there is a single code response with no body. commit: 2465407 (main), cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The net_packet_http and net_packet_http_response events are failing for empty replies (such as HTTP/1.x 200 OK replies, for example). Ignore if there is some EOF trying to parse response... it usually means there is a single code response with no body.