Chore at large #3979
Merged
Chore at large #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values returned by the removed methods are only used for computation, so it is unnecessary to expose them.
The field can be set directly, so the method is not needed.
Both policy and policies now have the same ContainerFilterEnabled() method returning a boolean value. The respective bitmap now is accessed via Policies WithContainerFilterEnabled().
GetContainerMode() can make use of the already computed policies information (container filters) via ContainerFilterEnabled().
This new file contains the logic for policies computation.
rscampos
reviewed
Apr 23, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
c5f3f8d chore(policy): move logic into policies_compute.go
1397714 chore(cmd): reuse already computed policies value
1d17a50 chore(policy): align policy and polices API
3faa9b8 chore(policy): rename consts and add PolicyNone
78305a9 chore(policy): remove SetVersion()
e8f4545 chore(policy): remove useless code
ea3998e chore: remove dead/duplicate code
c5f3f8d chore(policy): move logic into policies_compute.go
1397714 chore(cmd): reuse already computed policies value
1d17a50 chore(policy): align policy and polices API
78305a9 chore(policy): remove SetVersion()
e8f4545 chore(policy): remove useless code
2. Explain how to test it
3. Other comments