feat(ksyms): required ksym scanning #4088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NDStrahilevitz
commented
May 29, 2024
go.mod
Outdated
| @@ -180,3 +180,5 @@ require ( | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| kernel.org/pub/linux/libs/security/libcap/psx v1.2.68 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/aquasecurity/libbpfgo/helpers => ../libbpfgo/helpers | |||
There was a problem hiding this comment.
TODO: split PR and remove this
NDStrahilevitz
force-pushed
the
required_ksym_scanning
branch
from
0d01802
to
7a4bab4
Compare
Use modified ksymbols implementation. The new implementation may take a list of required symbols and addresses to track. If the list is given, symbol scanning will only save those symbols or addresses which were given in the list. If a new symbol is queried, then a rescan is needed. Refactor tracee initialization to find all necessary symbols to track ahead of runtime.
NDStrahilevitz
force-pushed
the
required_ksym_scanning
branch
from
7a4bab4
to
4f07d58
Compare
geyslan
reviewed
May 29, 2024
There was a problem hiding this comment.
I did a cursory review, but didn't tested yet. Put some questions.
There's this error in the tests: https://github.com/aquasecurity/tracee/actions/runs/9290348284/job/25574577060?pr=4088#step:5:1471
| @@ -1112,9 +1235,8 @@ func (t *Tracee) attachProbes() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (t *Tracee) initBPF() error { | |||
| func (t *Tracee) initBPFProbes() error { | |||
There was a problem hiding this comment.
Good. Logic split like that will make further refactor easier.
Comment on lines
+947
to
+948
| if _, ok := t.eventsState[events.PrintMemDump]; ok { | ||
| for it := t.config.Policies.CreateAllIterator(); it.HasNext(); { |
There was a problem hiding this comment.
These two accesses will need to be rethought in the future.
eventsStatehas a close relationship with policies, therefore it must either be incorporated into the policy package or a communication mechanism must be created between them.- instead of iterating policies to get a single event information we should provide it available via the PolicyManager (e.g.:
polManager.IsEventChosen(events.PrintMemDump).
|
To be replaced by #4092 that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
f922536 chore(go.mod): update libbpfgo helpers
0d01802 feat(ksymbols): restore lazy ksyms implementtion
2. Explain how to test it
No change in behavior, all previous tests should pass.
Memory should be reduced, testable with:
ps -ppgrep tracee-o pid,vsz,rss,cmdand check rss.
3. Other comments