chore: Move helpers package from libbpfgo to local repository #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied helpers package from libbpfgo to local repo to avoid dependency issues. This eliminates frequent updates of libbpfgo and simplifies our workflow. Allows faster bug fixes and updates, improving development efficiency.
Ensure safe type assertions in kernel config parsing to prevent potential panics. Used type switch assignment and added type checks for value comparisons.
geyslan
approved these changes
May 30, 2024
There was a problem hiding this comment.
Awesome.
This is the initial part to close aquasecurity/libbpfgo#243 and aquasecurity/libbpfgo#297.
P.S.: The libbpfgo incoming code lacks assertion checks which is enforced in Tracee via revive: https://github.com/aquasecurity/tracee/actions/runs/9305562614/job/25612793173?pr=4090#step:5:15
| ALMALINUX_MANTISBT_PROJECT="AlmaLinux-8" | ||
| ALMALINUX_MANTISBT_PROJECT_VERSION="8.7" | ||
| REDHAT_SUPPORT_PRODUCT="AlmaLinux" | ||
| REDHAT_SUPPORT_PRODUCT_VERSION="8.7" |
There was a problem hiding this comment.
nit: came with the missing blank end line.
Ensure errors from file closures are handled to prevent potential issues. - Added deferred anonymous functions to check and log errors from f.Close(). - Improved logging for better error tracking.
yanivagman
added a commit
to yanivagman/tracee
that referenced
this pull request
May 30, 2024
This commit integrates the libbpfgo packages into the tracee repository. These packages were previously copied over from libbpfgo in a separate PR (aquasecurity#4090) to resolve dependency issues. Now, tracee is utilizing these packages, providing better compatibility and ensuring smoother development.
yanivagman
added a commit
to yanivagman/tracee
that referenced
this pull request
May 30, 2024
This commit integrates the libbpfgo packages into the tracee repository. These packages were previously copied over from libbpfgo in a separate PR (aquasecurity#4090) to resolve dependency issues. Now, tracee is utilizing these packages, providing better compatibility and ensuring smoother development.
yanivagman
added a commit
that referenced
this pull request
May 30, 2024
This commit integrates the libbpfgo packages into the tracee repository. These packages were previously copied over from libbpfgo in a separate PR (#4090) to resolve dependency issues. Now, tracee is utilizing these packages, providing better compatibility and ensuring smoother development.
yanivagman
added a commit
to yanivagman/tracee
that referenced
this pull request
Jun 2, 2024
This commit integrates the libbpfgo packages into the tracee repository. These packages were previously copied over from libbpfgo in a separate PR (aquasecurity#4090) to resolve dependency issues. Now, tracee is utilizing these packages, providing better compatibility and ensuring smoother development.
yanivagman
added a commit
that referenced
this pull request
Jun 2, 2024
This commit integrates the libbpfgo packages into the tracee repository. These packages were previously copied over from libbpfgo in a separate PR (#4090) to resolve dependency issues. Now, tracee is utilizing these packages, providing better compatibility and ensuring smoother development.
This was referenced Jun 19, 2024
yanivagman
added a commit
to yanivagman/tracee
that referenced
this pull request
Jun 24, 2024
This commit integrates the libbpfgo packages into the tracee repository. These packages were previously copied over from libbpfgo in a separate PR (aquasecurity#4090) to resolve dependency issues. Now, tracee is utilizing these packages, providing better compatibility and ensuring smoother development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Copied helpers package from libbpfgo to local repo to avoid dependency issues. This eliminates frequent updates of libbpfgo and simplifies our workflow. Allows faster bug fixes and updates, improving development efficiency.
2. Explain how to test it
3. Other comments