[backport 0.21.0] Fix ksymbols mem consumption backport #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanivagman
changed the title
yanivagman
force-pushed
the
fix_ksymbols_mem_consumption_backport_0.21
branch
3 times, most recently
from
0b78f71
to
cf84b86
Compare
The hooked_syscalls and do_init_module events require CAP_SYSLOG in order to refresh its symbol table when reading /proc/kallsyms. Add these missing dependencies.
Use modified ksymbols implementation. The new implementation may take a list of required symbols and addresses to track. If the list is given, symbol scanning will only save those symbols or addresses which were given in the list. If a new symbol is queried, then a rescan is needed. Refactor tracee initialization to find all necessary symbols to track ahead of runtime. Co-authored-by: Geyslan Gregório <geyslan@gmail.com> Co-authored-by: Yaniv Agman <yanivagman@gmail.com>
This commit refactors the refresh logic of KernelSymbolTable to be sequential, removing the use of goroutines and channels. The decision to simplify the code was made for the following reasons: 1. Simplicity: The sequential approach simplifies the codebase, making it easier to understand, maintain, and debug. 2. Less Relevant Concurrency: With the introduction of "required symbols", the need for concurrency has been reduced. We now skip memory allocation for symbols that are not required, which constitutes the majority of the symbols in /proc/kallsyms.
yanivagman
force-pushed
the
fix_ksymbols_mem_consumption_backport_0.21
branch
from
cf84b86
to
a8a4a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Backport #4095 to v0.21.0 branch
2. Explain how to test it
3. Other comments