New modules logger, errfmt and environment

[geyslan]

Part of #4111 solution.

1. Explain what the PR does

1122db1 chore: use environment module
6ee5a54 chore: mv pkg/utils/environment into environment mod
4e7c7de chore: use errfmt module
efae8e6 chore: move pkg/errfmt into errfmt module
0e22c48 chore: use logger module
c211422 chore: move pkg/logger into logger module

2. Explain how to test it

3. Other comments

Well, there's no straight way of doing this relocation. So, after this merge will have at least 2 more PRs to point to the right modules hashes.

[rscampos]

LGTM

[geyslan]

@AlonZivony do you think this would help with #4111 matter? I ask since I know this will increase maintenance efforts for both ends. Decoupling in modules can be a start to move them to repos if the respective codebase demands it anyway.

[yanivagman]

A few thoughts:

1. Should we have so many modules? Maybe we can converge some?
2. Should they be under the root of the tree? Can't we put them under pkg?
3. Do we really want errfmt as a module (it doesn't have much logic in it).

Maybe we should remove the error handling from within the environment package and let the caller handle any returned errors?

[geyslan]

A few thoughts:

1. Should we have so many modules? Maybe we can converge some?

We should not have. I agree that converging them is the best approach to us. But we have to have in mind that splitting should avoid cyclic import issues.

2. Should they be under the root of the tree? Can't we put them under pkg?

If modules, bring them up to avoid cyclic import issues.

3. Do we really want errfmt as a module (it doesn't have much logic in it).

No, but it can be part of a converged module, like utils - I know, I know, utils is the worse naming option, but since we would converge different pkgs into it, they could be imported like utils/errfmt, utils/environment...

Maybe we should remove the error handling from within the environment package and let the caller handle any returned errors?

Well, this is an option too.

[geyslan]

We are choosing another approach. #4129