Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.21.0] chore: possible fix for size/RSS issue #4132

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

rscampos
Copy link
Contributor

1. Explain what the PR does

c943766 chore: Possible fix for size/RSS issue

Using scheme package increases the binary size because it includes
additional code and dependencies related to Kubernetes. It also
increases the RSS memory.

Because we don't need the entire scheme package, only
apimachinery/runtime package was used to create a new scheme.

commit: 3b5175d (main), cherry-pick

2. Explain how to test it

3. Other comments

Using scheme package increases the binary size because it includes
additional code and dependencies related to Kubernetes. It also
increases the RSS memory.

Because we don't need the entire scheme package, only
apimachinery/runtime package was used to create a new scheme.

commit: 3b5175d (main), cherry-pick
@rscampos rscampos self-assigned this Jun 19, 2024
@rscampos rscampos changed the title [v0.21.0] chore: Possible fix for size/RSS issue [v0.21.0] chore: possible fix for size/RSS issue Jun 19, 2024
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscampos rscampos merged commit 2d8d4a3 into aquasecurity:v0.21.0 Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants