Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use dev tag for docker image building #4138

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jun 21, 2024

This is a continuation of #4137.

1. Explain what the PR does

89dd6d0 chore(ci): use dev tag for docker image building

When SNAPSHOT=1, the local docker image will be tagged with dev tag to
differentiate it from the official release which is tagged with the
latest tag.

2. Explain how to test it

3. Other comments

When SNAPSHOT=1, the local docker image will be tagged with dev tag to
differentiate it from the official release which is tagged with the
latest tag.
@geyslan geyslan requested a review from rscampos June 21, 2024 13:15
@geyslan geyslan self-assigned this Jun 21, 2024
Copy link
Contributor

@rscampos rscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit 1085fc5 into aquasecurity:main Jun 21, 2024
3 checks passed
geyslan added a commit that referenced this pull request Jun 22, 2024
When SNAPSHOT=1, the local docker image will be tagged with dev tag to
differentiate it from the official release which is tagged with the
latest tag.

commit: 1085fc5 (main), cherry-pick
geyslan added a commit that referenced this pull request Jun 22, 2024
* chore(ci): use dev tag for docker image building (#4138)

When SNAPSHOT=1, the local docker image will be tagged with dev tag to
differentiate it from the official release which is tagged with the
latest tag.

commit: 1085fc5 (main), cherry-pick

* chore: install last version of golang

commit: 6c111b4 (main), cherry-pick

* chore: golang binary move to tmp

commit: 221b0ac (main), cherry-pick

* fix: arm64 clang issue

commit: 6cc06b2 (main), cherry-pick

* fix(ci): make release rule to have prerequisites (#4141)

These changes ensure that the 'release' rule will require the other
rules to be executed (splitting the commands into different rules). This
way, if any some of the rules fail, the build will be aborted right away.

commit: 86c2c16 (main), cherry-pick

* fix(build): extract OPA 0.66 from OPA dev image

This workaround is required since OPA 0.65.0 (latest published release)
has cve-2024-24790.

After solved we can rollback to the previouw installation method.

commit: ef7d74e (main), cherry-pick

* fix(build): mv gh release logic to release rule (#4145)

Continuation of #4141.

commit: 6f94719 (main), cherry-pick

---------

Co-authored-by: Raphael Campos <raphaelcampos.rp@gmail.com>
@geyslan geyslan deleted the make-docker-tag-clear branch June 28, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants