Revert "chore(sig): define signature metadata statically" #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
approved these changes
Sep 23, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4237
Initially, we improved performance by statically defining the metadata of a signature. However, we later discovered a data race issue when a JSON library attempted to iterate over the properties of the detect.SignatureMetadata map while another goroutine was modifying the same object.
A possible future improvement would be to transform the metadata, which currently uses abstract types, into concrete types. This would allow us to statically define it without any issues.
The issues that arose after migrating the signature metadata to be static:
#4313
#4298