Skip to content

chore: explicit revive rules #12879

chore: explicit revive rules

chore: explicit revive rules #12879

Triggered via pull request January 24, 2025 12:19
Status Failure
Total duration 17m 7s
Artifacts

test.yaml

on: pull_request
Integration Test
11m 16s
Integration Test
K8s Integration Test
5m 27s
K8s Integration Test
Module Integration Test
4m 48s
Module Integration Test
VM Integration Test
8m 3s
VM Integration Test
Matrix: Build Test
Matrix: Test
Fit to window
Zoom out
Zoom in

Annotations

15 errors and 6 warnings
Test (ubuntu-latest)
Process completed with exit code 1.
Test (ubuntu-latest): pkg/dependency/parser/java/pom/parse.go#L552
early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ... (revive)
Test (ubuntu-latest): pkg/dependency/parser/java/pom/parse.go#L561
early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ... (revive)
Test (ubuntu-latest): pkg/dependency/parser/java/pom/parse.go#L569
early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ... (revive)
Test (ubuntu-latest): pkg/dependency/parser/java/pom/parse.go#L41
unexported-return: exported func WithOffline returns unexported type pom.option, which can be annoying to use (revive)
Test (ubuntu-latest): pkg/dependency/parser/java/pom/parse.go#L47
unexported-return: exported func WithReleaseRemoteRepos returns unexported type pom.option, which can be annoying to use (revive)
Test (ubuntu-latest): pkg/dependency/parser/java/pom/parse.go#L53
unexported-return: exported func WithSnapshotRemoteRepos returns unexported type pom.option, which can be annoying to use (revive)
Test (ubuntu-latest): pkg/iac/scanners/azure/arm/parser/template.go#L60
receiver-naming: receiver name v should be consistent with previous receiver name r for Resource (revive)
Test (ubuntu-latest): pkg/iac/scanners/azure/functions/date_time_add.go#L66
early-return: if c { ... } else { ... return } can be simplified to if !c { ... return } ... (revive)
Test (ubuntu-latest): pkg/dependency/parser/rust/cargo/naive_pkg_parser.go#L31
var-declaration: should omit type minPkg from declaration of var currentPkg; it will be inferred from the right-hand side (revive)
Test (ubuntu-latest): pkg/dependency/parser/rust/cargo/parse.go#L124
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
Test (windows-latest)
The job was canceled because "ubuntu-latest" failed.
Test (windows-latest)
The operation was canceled.
Test (macos-latest)
The job was canceled because "ubuntu-latest" failed.
Test (macos-latest)
The operation was canceled.
Module Integration Test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
K8s Integration Test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Test (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
VM Integration Test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Integration Test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build Test (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636