Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add terminology page to explain Trivy concepts #7996

Merged
merged 11 commits into from
Nov 29, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

This PR adds a new terminology page that documents the key concepts and terms used in Trivy.
The page covers core components, scanning features, and infrastructure elements.

Note: The term "Scan Assets" is newly introduced in this PR to collectively refer to external data that Trivy downloads and uses during scanning (e.g., vulnerability database, Java database, checks bundle).

The goal is to provide a single source of truth for Trivy terminology and help users better understand the project's architecture and components.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this Nov 26, 2024
@knqyf263 knqyf263 requested a review from a team November 26, 2024 07:20
@knqyf263
Copy link
Collaborator Author

@aquasecurity/trivy The definition of the terminology system will be helpful for our communication and document updates, so please look over it and feel free to leave any feedback.

@knqyf263 knqyf263 added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 26, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263 and others added 5 commits November 27, 2024 09:32
Co-authored-by: simar7 <1254783+simar7@users.noreply.github.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@simar7
Copy link
Member

simar7 commented Nov 29, 2024

LGTM, but I'll wait for @nikpivkin and @DmitriyLewen to also take a look.

docs/docs/references/terminology.md Outdated Show resolved Hide resolved
Types of artifacts that Trivy can scan, like container images and filesystem.

### Scanner
Trivy's built-in security scanning engines. Trivy has four main scanners:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scanners flag only allows these 4 scanners.
But there is "shadow" scanner sbom (e.g. when we use the SBOM format).

Is it worth mentioning?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Mentioned.
6e8cf5f

docs/docs/references/terminology.md Outdated Show resolved Hide resolved
- https://github.com/aquasecurity/vuln-list-redhat
- https://github.com/aquasecurity/vuln-list-debian
- etc.
-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This - creates extra dot:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Deleted 26d3cf4

knqyf263 and others added 4 commits November 29, 2024 11:19
Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
Co-authored-by: DmitriyLewen <91113035+DmitriyLewen@users.noreply.github.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@DmitriyLewen
Copy link
Contributor

@knqyf263 can you rewrite CLA?

@DmitriyLewen DmitriyLewen added this pull request to the merge queue Nov 29, 2024
@knqyf263
Copy link
Collaborator Author

Tip: You can request that the CLA assistant run again by https://cla-assistant.io/check/aquasecurity/trivy?pullRequest=7996.

Merged via the queue into aquasecurity:main with commit eaf8d41 Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants