Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: delete unneeded versions #8183

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Conversation

itaysk
Copy link
Contributor

@itaysk itaysk commented Dec 26, 2024

Description

Delete unneeded versions from docs website version selector

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@itaysk itaysk requested review from nikpivkin and knqyf263 December 26, 2024 12:43
Comment on lines +250 to +251
"v0.18.0",
"v0.18.1"
Copy link
Collaborator

@knqyf263 knqyf263 Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm just curious why the order of these versions was changed. Is it needed for some reason?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a formatter thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it too, not sure why.. I just ran the mike command. I actually run it from the same container image that is used in the gh workflow so it should be exactly the same environment. wild guess is that the delete command (which I used now, but is rarely used otherwise) does a more extensive manipulation of the file than the deploy command (that we use regularly when building the docs.

@knqyf263 knqyf263 merged commit e600be1 into aquasecurity:gh-pages Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants