Quickfix approvals cache

aragon · Oct 26, 2023 · 030e2bc · 030e2bc
1 parent af7534d
commit 030e2bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/context/proposalTransaction.tsx b/src/context/proposalTransaction.tsx
@@ -8,8 +8,8 @@ import {
 } from '@aragon/sdk-client';
 import {useQueryClient} from '@tanstack/react-query';
 import React, {
-  ReactNode,
   createContext,
+  ReactNode,
   useCallback,
   useContext,
   useMemo,
@@ -341,11 +341,13 @@ const ProposalTransactionProvider: React.FC<Props> = ({children}) => {
       }
 
       if (voteToPersist) {
-        voteStorage.addVote(
-          CHAIN_METADATA[network].id,
-          proposalId.toString(),
-          voteToPersist
-        );
+        // todo(kon): quickfix to use the proposal id on the same format when we are retrieving the proposal from the
+        // minsdk. We should use the proposal id on the same format everywhere after refactor
+        const propId =
+          pluginType === GaselessPluginName
+            ? '0x' + proposalId.stripPlgnAdrFromProposalId().proposal.toString()
+            : proposalId.toString();
+        voteStorage.addVote(CHAIN_METADATA[network].id, propId, voteToPersist);
       }
 
       invalidateProposalQueries();
@@ -392,6 +394,9 @@ const ProposalTransactionProvider: React.FC<Props> = ({children}) => {
 
   // handles vote submission/execution
   const handleVoteExecution = useCallback(async () => {
+    console.log('UUUUUUUUU');
+    onVoteSubmitted(new ProposalId(urlId!), VoteValues.YES, false);
+    return;
     if (voteProcessState === TransactionState.SUCCESS) {
       handleCloseVoteModal();
       return;
@@ -490,6 +495,7 @@ const ProposalTransactionProvider: React.FC<Props> = ({children}) => {
 
   // handles proposal execution
   const handleProposalExecution = useCallback(async () => {
+    console.log('AAAAAAAA');
     if (executeProcessState === TransactionState.SUCCESS) {
       handleCloseExecuteModal();
       return;

diff --git a/src/services/aragon-sdk/selectors/proposal.ts b/src/services/aragon-sdk/selectors/proposal.ts
@@ -143,15 +143,15 @@ function syncApprovalsOrVotes(
 ): void {
   if (isMultisigProposal(proposal)) {
     proposal.approvals = syncMultisigVotes(chainId, proposal);
-  } else if (isTokenBasedProposal(proposal)) {
-    proposal.votes = syncTokenBasedVotes(chainId, proposal);
   } else if (isGaslessProposal(proposal)) {
     // todo(kon): gasless vote array is not yet implemented
     const {gaslessVotes, approvers} = syncGaslessVotesOrApproves(
       chainId,
       proposal
     );
     proposal.approvers = approvers;
+  } else if (isTokenBasedProposal(proposal)) {
+    proposal.votes = syncTokenBasedVotes(chainId, proposal);
   }
 }