Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-2549: Field validation for WC QR code input #1086

Merged
merged 5 commits into from
Oct 31, 2023
Merged

APP-2549: Field validation for WC QR code input #1086

merged 5 commits into from
Oct 31, 2023

Conversation

RakeshUP
Copy link
Contributor

@RakeshUP RakeshUP commented Oct 23, 2023

Description

TODO: Crowdin key for error message pending from discovery. Will update that before merging this PR.

Task: APP-2549

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@RakeshUP RakeshUP requested a review from a team October 23, 2023 10:47
@RakeshUP RakeshUP marked this pull request as ready for review October 23, 2023 10:48
@RakeshUP RakeshUP requested a review from cgero-eth October 24, 2023 13:16
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RakeshUP, let's wait for the new translation key to merge the PR 👌🏻

@RakeshUP RakeshUP merged commit 4cc5355 into develop Oct 31, 2023
@RakeshUP RakeshUP deleted the f/2549 branch October 31, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants