fix(APP-3261): Truncate long link descriptions dashboard #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Barukimang
force-pushed
the
fix/app-3261-long-link-description
branch
from
f356db4 to
d33caca
Compare
There was a problem hiding this comment.
Thanks @Barukimang! Left an alternative idea for your fix. Let me know what you think. 🫴🦋
cgero-eth
changed the title
cgero-eth
reviewed
Jul 1, 2024
| @@ -202,45 +202,47 @@ export const HeaderDao: React.FC<HeaderDaoProps> = ({ | |||
| <DetailsText>{daoType}</DetailsText> | |||
| </NetworkDetails> | |||
| </NetworkDetailsContainer> | |||
| <ActionWrapper> | |||
There was a problem hiding this comment.
@Barukimang The links should still be placed on the right side of the page, right?
There was a problem hiding this comment.
Since these style changes introduced a new issue and this 🐛 was a tiny edge case to start with, closing this PR and submitting a new PR with the initial fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dashboard UI fix, bringing default displayed shown back from 3 to 2, see BEFORE and AFTER in the images below:
BEFORE
AFTER
Task: APP-3261
Type of change
Checklist: