Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete proposal execution flows #73

Merged
merged 12 commits into from
Feb 27, 2024
Merged

Complete proposal execution flows #73

merged 12 commits into from
Feb 27, 2024

Conversation

brickpop
Copy link
Contributor

  • Allow to execute proposals that passed on token voting
  • Show the execute button only when applicable
  • Encapsulate the execution logic in two dedicated hooks
  • Remove the logic-in-UI code
  • Show the minimum veto voting power
  • Show the minimum turnout
  • Display the token symbol to signify that the unit relates to a token balance
  • Format all the threshold numbers

Other:

  • Using sequential if/then else flows to detect the proposal status
  • Adding a "no votes" and "no vetoes" placeholder message
  • Unify the "active" colours and make "executed" tags look different than "execute"
  • Display votes consecutively and not in vertical uneven columns
  • Lighter props passing by using hooks only where needed

Copy link
Collaborator

@carlosgj94 carlosgj94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially I think would be amazing if we could move the token related hooks outside of the plugin dirs and make them generic and consumable by the plugins.

I'm approving nonetheless, give that a thought and choose if you want that inside this PR or on another following one

@brickpop brickpop merged commit a17f88d into main Feb 27, 2024
2 checks passed
@brickpop brickpop deleted the f/execute-proposals branch February 27, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants