Fix compatibility with PHP 7.3 #451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex fails to parse in PHP 7.3, which broke the page in later functions. ``` PHP Warning: preg_replace(): Compilation failed: invalid range in character class at offset 4 in /var/www/felixcat/wp-content/plugins/crayon-syntax-highlighter/crayon_langs.class.php on line 340 ```
|
@felixonmars - don't suppose you have Crayon working with WP 5.0? |
|
Indeed, I am running Crayon with WP 5.0 under PHP 7.3. |
|
Interesting!
I’m still on PHP 7.2 at the mo but running WP 5.0!
How are declaring language options in the blocks? I only realised through
fiddling this evening that when I add a code block, it is formatted by
Crayon on the front-end, but I’ve not yet found a way to declare which
language I’m writing!
…On Tue, 11 Dec 2018 at 19:03, Felix Yan ***@***.***> wrote:
Indeed, I am running Crayon with WP 5.0 under PHP 7.3.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#451 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Apt9Ah5CgTQM-5m6h3D8tAGomZBNzFbyks5u4AFtgaJpZM4ZKSDA>
.
|
|
I've been using |
|
Brilliant! Are you just wrapping it manually by "Edit block as HTML"? |
|
Yes. |
|
perfect ,! |
tiefpunkt
approved these changes
Apr 29, 2020
|
Is this ever gonna be released? I spent a lot of time today to figure out the same issue before finding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex fails to parse in PHP 7.3, which broke the page in later functions.