Skip to content

Conversation

bluepal-prasanthi-moparthi
Copy link
Collaborator

@bluepal-prasanthi-moparthi bluepal-prasanthi-moparthi commented Sep 30, 2025

This PR includes the following general-request-handling- related endpoints:

  1. GET - /_admin/version
  2. GET - /_admin/status

Note

Introduces _admin/version via new HandleAdminVersion and updates GetServerStatus to use global _admin/status when dbName is empty, with expanded tests and minor test robustness improvements.

  • Backend/API:
    • Add HandleAdminVersion(opts) to fetch version via _admin/version (alias of _api/version).
    • Enhance GetServerStatus to support both _db/{db}/_admin/status and global _admin/status when dbName is empty.
  • Tests:
    • Add Test_HandleAdminVersion (with/without options).
    • Expand Test_GetServerStatus to cover no DB, with DB, and invalid DB cases.
    • Improve access token tests: use UUID names, retry on 409 conflicts, add cleanup helper, extra nil checks.
  • Docs:
    • Update v2/CHANGELOG.md to note general-request-handling endpoints.

Written by Cursor Bugbot for commit d7c7672. This will update automatically on new commits. Configure here.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing general request handling endpoints to the ArangoDB Go driver v2, specifically implementing admin version and status endpoints. The implementation includes proper handling of both database-scoped and global admin requests.

  • Added HandleAdminVersion method that provides an alias for GET /_admin/version with optional details
  • Updated GetServerStatus to support both global (/_admin/status) and database-scoped (/_db/{name}/_admin/status) requests
  • Added comprehensive test coverage for both new and updated functionality

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
v2/arangodb/client_server_info.go Adds AdminVersionInfo struct and HandleAdminVersion interface method
v2/arangodb/client_server_info_impl.go Implements HandleAdminVersion method with proper error handling
v2/arangodb/client_admin_impl.go Updates GetServerStatus to handle empty dbName for global status requests
v2/tests/admin_test.go Adds comprehensive tests for both HandleAdminVersion and updated GetServerStatus behavior
v2/CHANGELOG.md Documents the addition of general-request-handling endpoints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bluepal-prasanthi-moparthi bluepal-prasanthi-moparthi force-pushed the feature/add_mis_endpoints_in_general branch from d458233 to fe08d20 Compare September 30, 2025 12:00
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant