Open
Conversation
aravindvnair99
requested changes
Jun 22, 2021
Owner
aravindvnair99
left a comment
There was a problem hiding this comment.
@abirbhattacharya82 Nice work. Take a look at this as well:
The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20).
Specify a limit to %s, or use a different input function.
Refer: https://www.codefactor.io/repository/github/aravindvnair99/c/pull/24
Author
|
Check Now. I have restricted it. |
aravindvnair99
requested changes
Oct 1, 2021
Owner
aravindvnair99
left a comment
There was a problem hiding this comment.
Hey @abirbhattacharya82!
Sorry for the delay in getting back to you. I must have dismissed the notification accidentally. Could you look at the Codacy analysis results for your PR and resolve them? I will merge your PR once you are done with it.
Owner
|
Hey @abirbhattacharya82! Any updates? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Added Input Validations to prior program
Summary:
A program added that will find the maximum and minimum elements of an array by the Tournament Method. It uses the Divide and Conquer Algorithm.