-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no event triggered when user goes back to homepage #3
base: master
Are you sure you want to change the base?
Conversation
Did the tests passed locally? The build is failing |
test doesn't work as it is looking for a global polvo: Building app before testing.. so locally the tests doesn't even start |
Regardless of passing tests, i think the issue is more agreeing to remove the "initial" / "popped" trick. Worth noticing:
Once that is fixed ( not sure if we just comment out, or we do a method, whatever you think suits your standards ), then we can re-write the tests accordingly. |
Any change will require tests to be adjusted or rewrote, the global polvo thing is surely a mistake, just swap the lines setting the polvo variable inside the Makefile. This trick you've mentioned is a behavior-normalization across all browsers, it cannot be simply removed. Check the tests for more info. |
Also perhaps travis if failing regardless of the pull request: https://travis-ci.org/serpentem/ways-browser: https://github.com/serpentem/ways-browser |
Fixed comment line with missing #
Unfortunately i didn't have time to create the test case for it.
Actually perhaps you had some issues if this already, hence why you had that "initial" and "popped" flags.
Perhaps on my "real use case" ( using ways, without calling ways.init ), those variables creates the bug i refer @ #2