Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no event triggered when user goes back to homepage #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

no event triggered when user goes back to homepage #3

wants to merge 5 commits into from

Conversation

hems
Copy link

@hems hems commented Apr 28, 2014

Unfortunately i didn't have time to create the test case for it.

Actually perhaps you had some issues if this already, hence why you had that "initial" and "popped" flags.

Perhaps on my "real use case" ( using ways, without calling ways.init ), those variables creates the bug i refer @ #2

@arboleya
Copy link
Owner

Did the tests passed locally? The build is failing

@hems
Copy link
Author

hems commented Apr 28, 2014

test doesn't work as it is looking for a global polvo:

Building app before testing..
/bin/sh: polvo: command not found

so locally the tests doesn't even start

@hems
Copy link
Author

hems commented Apr 28, 2014

Regardless of passing tests, i think the issue is more agreeing to remove the "initial" / "popped" trick.

Worth noticing:

  • On my case, the template is already rendered so I don't need to do ways.init()
  • That "initial" / "popped" trick was silently blocking my url:change event when going back to the homepage for the first time

Once that is fixed ( not sure if we just comment out, or we do a method, whatever you think suits your standards ), then we can re-write the tests accordingly.

@arboleya
Copy link
Owner

Any change will require tests to be adjusted or rewrote, the global polvo thing is surely a mistake, just swap the lines setting the polvo variable inside the Makefile.

This trick you've mentioned is a behavior-normalization across all browsers, it cannot be simply removed. Check the tests for more info.

@hems
Copy link
Author

hems commented Apr 28, 2014

Also perhaps travis if failing regardless of the pull request: https://travis-ci.org/serpentem/ways-browser: https://github.com/serpentem/ways-browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants