Merge pull request #12 from Constructor-io/pe-671/error-on-flush-fail

fix: return error if flush fails
archdx · Oct 6, 2023 · 76f3772 · 76f3772
2 parents 02582d2 + 520f730
commit 76f3772
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/errors.go b/errors.go
@@ -0,0 +1,7 @@
+package zlogsentry
+
+import (
+	"errors"
+)
+
+var ErrFlushTimeout = errors.New("zlogsentry flush timeout")
diff --git a/writer.go b/writer.go
@@ -83,7 +83,9 @@ func (w *Writer) WriteLevel(level zerolog.Level, p []byte) (n int, err error) {
 // Close forces client to flush all pending events.
 // Can be useful before application exits.
 func (w *Writer) Close() error {
-	w.hub.Flush(w.flushTimeout)
+	if ok := w.hub.Flush(w.flushTimeout); !ok {
+		return ErrFlushTimeout
+	}
 	return nil
 }