Feature/hdf5 1.14.4 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/ci.yml
Remove mismatched_lifetime_syntaxes and unpredictable_function_pointer_comparisons from Cargo.toml, fixing the underlying issues in code instead: - Replace impl Trait for Type<'_> with explicit lifetime parameters - Replace function pointer comparison with direct type ID comparison using H5Tequal() - Add explicit '_ for elided lifetimes in return positions where required
- Fix mismatched closing delimiter in test_dataset_builder macro - Fix test_builder_methods macro by using proper repetition syntax - Add local with_tmp_file helper function - Remove unused Array1 import
- Update MSRV to 1.92 - Update GitHub Actions to checkout@v4 - Update dependencies: ndarray 0.16, bitflags 2.6 - Apply let_else patterns for more idiomatic code - Refine clippy lint configuration - Fix various clippy warnings (derivable_impls, needless_lifetimes, etc.) - Fix rustfmt.toml edition to 2021
- Simplified job structure with clearer naming - Combined fmt and clippy into single lint job - Focused on essential test scenarios - Multi-platform static build testing (Linux, macOS, Windows) - MSRV testing - Documentation build - Feature combination testing - Removed redundant jobs for faster feedback
- Fix blosc test: use direct method calls instead of closure array - Remove unused imports (BuilderTestCase, Filter, IxDyn, TryInto, Conversion, TypeDescriptor) - Fix unnecessary parentheses warning in .shape() calls - Fix unused variable warning (_ds prefix)
- Remove unused macros: test_dataset_builder, apply_config, test_dataset_configs, test_builder_methods - Fix blosc test: use method chaining instead of intermediate mutable bindings
- Simplify apply_config macro to expand to method fragments - Fix test_dataset_builder macro to use method chaining - Document unused macros for future use - Add test for apply_config macro behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the bundled HDF5 library from version 1.14.3 to 1.14.4 and modernizes the codebase to follow 2026 Rust best practices.
Key Changes
HDF5 Upgrade
chunk_infofor 1.14.4 compatibilityhdf5-srcis included for static builds on macOSCodebase Modernization
Testing & Coverage
dataset_test_utils.rs)test_dataset_coverage.rs)CI/CD Improvements
Test Plan