Update types imported from aws-sdk #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types test pass again
also arc.ws._api returns client.ApiGatewayManagementApi -- need to double check this is correct
|
Can you check my work on this change to |
|
Great catch, thank you @tbeseda! |
also remove some old JSDoc since it's mixing with .d.ts in a confusing way for consumers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to arc/functions types removes references to
aws-sdkand overall improves accuracy of all types.there are still a couple concessions that I think could be improved in the future, but this iteration is certainly the best we've had yet.
in the future, I think these types can be simplified by inheriting more from aws-lite directly. further, if a future version of arc/fns removes the callback pattern for most methods, we could eliminate all overload typing which accounts for a large chunk of definitions. just a note for future work.