Fix crash in leggings #16
Merged
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reported crash occurs in hexPantsStack.ifPresent, when the item is cast to a HexArmorItem. How this happens is a mystery, as we've already checked that it can be cast in an earlier step. Is the item somehow changing in the stack between check and use, or am I missing something obvious? To work around this we're performing the cast immediately after checking it is possible and saving the result for later. Closes #15
arconyx
commented
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reported crash occurs in
hexPantsStack.ifPresent, when the item is cast to aHexArmorItem. How this happens is a mystery, as we've already checked that it can be cast in an earlier step. Is the item somehow changing in the stack between check and use, or am I missing something obvious?To work around this we're performing the cast immediately after checking it is possible and saving the result for later.
Closes #15