Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Release Changes #1962

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Upcoming Release Changes #1962

merged 1 commit into from
Jan 10, 2025

Conversation

theguild-bot
Copy link
Collaborator

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/fetch@0.10.3

Patch Changes

  • #1961
    2785c80
    Thanks @ardatan! - ReadableStream's Symbol.asyncIterator now
    returns AsyncIterableIterator like before even if it is ok to return AsyncIterator right now.
    It is safer to return AsyncIterableIterator because it is a common mistake to use
    AsyncIterator as AsyncIterable.
  • Updated dependencies
    [2785c80]:
    • @whatwg-node/node-fetch@0.7.7

@whatwg-node/node-fetch@0.7.7

Patch Changes

  • #1961
    2785c80
    Thanks @ardatan! - ReadableStream's Symbol.asyncIterator now
    returns AsyncIterableIterator like before even if it is ok to return AsyncIterator right now.
    It is safer to return AsyncIterableIterator because it is a common mistake to use
    AsyncIterator as AsyncIterable.

@e2e/aws-lambda@0.0.37

Patch Changes

  • Updated dependencies
    [2785c80]:
    • @whatwg-node/fetch@0.10.3

@e2e/shared-server@0.0.128

Patch Changes

  • Updated dependencies
    [2785c80]:
    • @whatwg-node/fetch@0.10.3

@e2e/vercel@0.0.128

Patch Changes

  • Updated dependencies []:
    • @e2e/shared-server@0.0.128

@theguild-bot theguild-bot force-pushed the changeset-release/master branch from 29ebf3b to 48b5086 Compare January 10, 2025 09:34
Copy link
Contributor

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
@whatwg-node/fetch 0.10.3-rc-20250110093600-48b5086ea3535f34641fd8559221fa26fe734251 npm ↗︎ unpkg ↗︎
@whatwg-node/node-fetch 0.7.7-rc-20250110093600-48b5086ea3535f34641fd8559221fa26fe734251 npm ↗︎ unpkg ↗︎

Copy link
Contributor

@benchmarks/server results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 219324      ✗ 0     
     data_received..................: 22 MB   735 kB/s
     data_sent......................: 8.8 MB  292 kB/s
     http_req_blocked...............: avg=1.39µs   min=882ns    med=1.19µs   max=208.52µs p(90)=1.85µs   p(95)=2µs     
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=111.97µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=211.71µs min=156.22µs med=200.69µs max=40.58ms  p(90)=227.6µs  p(95)=237.62µs
       { expected_response:true }...: avg=211.71µs min=156.22µs med=200.69µs max=40.58ms  p(90)=227.6µs  p(95)=237.62µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 109662
     http_req_receiving.............: avg=25.81µs  min=13.4µs   med=24.09µs  max=3.37ms   p(90)=31.08µs  p(95)=34.51µs 
     http_req_sending...............: avg=6.28µs   min=3.93µs   med=5.49µs   max=293.86µs p(90)=7.97µs   p(95)=8.66µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=179.61µs min=129.78µs med=169.14µs max=40.5ms   p(90)=192.26µs p(95)=200.95µs
     http_reqs......................: 109662  3655.276998/s
     iteration_duration.............: avg=269.13µs min=198.18µs med=257.28µs max=40.71ms  p(90)=287.71µs p(95)=299.91µs
     iterations.....................: 109662  3655.276998/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/node-fetch results (consumeBody)

   ✓ active_handles.................: avg=139.303088 min=24      med=138     max=192     p(90)=163     p(95)=169    
     data_received..................: 21 MB  692 kB/s
     data_sent......................: 13 MB  443 kB/s
     http_req_blocked...............: avg=3.65µs     min=641ns   med=1.33µs  max=6.32ms  p(90)=2.02µs  p(95)=2.32µs 
     http_req_connecting............: avg=1.78µs     min=0s      med=0s      max=5ms     p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=22.04ms    min=4.74ms  med=21.4ms  max=1.15s   p(90)=27.78ms p(95)=29.97ms
       { expected_response:true }...: avg=22.04ms    min=4.74ms  med=21.4ms  max=1.15s   p(90)=27.78ms p(95)=29.97ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 135630
     http_req_receiving.............: avg=35.06µs    min=9.22µs  med=24.5µs  max=29.14ms p(90)=38.56µs p(95)=45.17µs
     http_req_sending...............: avg=10.48µs    min=3.31µs  med=6.32µs  max=14.22ms p(90)=9.79µs  p(95)=13.59µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=22ms       min=4.7ms   med=21.36ms max=1.15s   p(90)=27.73ms p(95)=29.89ms
     http_reqs......................: 135630 4520.553788/s
     iteration_duration.............: avg=44.2ms     min=18.61ms med=42.56ms max=1.18s   p(90)=48.54ms p(95)=54.1ms 
     iterations.....................: 67789  2259.410313/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/node-fetch results (noConsumeBody)

   ✓ active_handles.................: avg=140.761195 min=18      med=141     max=178     p(90)=158     p(95)=163    
     data_received..................: 22 MB  717 kB/s
     data_sent......................: 14 MB  464 kB/s
     http_req_blocked...............: avg=3.81µs     min=602ns   med=1.38µs  max=5.17ms  p(90)=2.04µs  p(95)=2.32µs 
     http_req_connecting............: avg=1.78µs     min=0s      med=0s      max=5.14ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.27ms    min=4.23ms  med=20.7ms  max=1.14s   p(90)=26.64ms p(95)=28.15ms
       { expected_response:true }...: avg=21.27ms    min=4.23ms  med=20.7ms  max=1.14s   p(90)=26.64ms p(95)=28.15ms
     http_req_failed................: 0.00%  ✓ 1           ✗ 140502
     http_req_receiving.............: avg=35.9µs     min=9.74µs  med=24.04µs max=32.44ms p(90)=38.77µs p(95)=46.17µs
     http_req_sending...............: avg=12.35µs    min=3.24µs  med=6.86µs  max=8.39ms  p(90)=10.16µs p(95)=14.37µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.23ms    min=4.2ms   med=20.66ms max=1.14s   p(90)=26.59ms p(95)=28.09ms
     http_reqs......................: 140503 4682.995959/s
     iteration_duration.............: avg=42.67ms    min=13.95ms med=41.12ms max=1.17s   p(90)=47.02ms p(95)=52.36ms
     iterations.....................: 70233  2340.881371/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100 

Copy link
Contributor

@benchmarks/server results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 299022      ✗ 0     
     data_received..................: 30 MB   982 kB/s
     data_sent......................: 12 MB   399 kB/s
     http_req_blocked...............: avg=1.37µs  min=852ns    med=1.17µs   max=170.27µs p(90)=1.86µs   p(95)=2.04µs  
     http_req_connecting............: avg=0ns     min=0s       med=0s       max=122.61µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=138.6µs min=92.6µs   med=134.32µs max=6.11ms   p(90)=155.92µs p(95)=162.82µs
       { expected_response:true }...: avg=138.6µs min=92.6µs   med=134.32µs max=6.11ms   p(90)=155.92µs p(95)=162.82µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 149511
     http_req_receiving.............: avg=24.33µs min=11.83µs  med=22.88µs  max=2.69ms   p(90)=29.97µs  p(95)=32.64µs 
     http_req_sending...............: avg=6.26µs  min=4.07µs   med=5.41µs   max=348.13µs p(90)=8.09µs   p(95)=8.75µs  
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=108µs   min=66.45µs  med=103.28µs max=5.82ms   p(90)=121.98µs p(95)=127.71µs
     http_reqs......................: 149511  4983.526238/s
     iteration_duration.............: avg=196.2µs min=138.53µs med=191.21µs max=6.21ms   p(90)=216.05µs p(95)=224.86µs
     iterations.....................: 149511  4983.526238/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

Copy link
Contributor

@benchmarks/server results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 204664      ✗ 0     
     data_received..................: 21 MB   686 kB/s
     data_sent......................: 8.2 MB  273 kB/s
     http_req_blocked...............: avg=1.46µs   min=861ns    med=1.23µs   max=184.24µs p(90)=1.95µs   p(95)=2.17µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=122.09µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=229.16µs min=171.64µs med=218.17µs max=7.71ms   p(90)=245.71µs p(95)=256.76µs
       { expected_response:true }...: avg=229.16µs min=171.64µs med=218.17µs max=7.71ms   p(90)=245.71µs p(95)=256.76µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 102332
     http_req_receiving.............: avg=26.39µs  min=14.06µs  med=24.75µs  max=2.83ms   p(90)=32.05µs  p(95)=34.98µs 
     http_req_sending...............: avg=6.6µs    min=4.06µs   med=5.92µs   max=691.64µs p(90)=8.37µs   p(95)=9.43µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=196.16µs min=144.4µs  med=185.41µs max=7.64ms   p(90)=210.1µs  p(95)=220.28µs
     http_reqs......................: 102332  3410.906708/s
     iteration_duration.............: avg=288.51µs min=216.22µs med=276.74µs max=7.85ms   p(90)=307.55µs p(95)=321.43µs
     iterations.....................: 102332  3410.906708/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1   

@ardatan ardatan merged commit 02c97ae into master Jan 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants