Update uotghs_host.c #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you try to read longer messages (>256 bytes) from USB device from host side, the buffer rolls over overwriting the buffer. For DUE/SAM can handle pipes with 1024 bytes, a uint16_t should be used.
per1234
suggested changes
Apr 23, 2019
system/libsam/source/uotghs_host.c
Outdated
| @@ -360,7 +360,7 @@ void UHD_Pipe_Free(uint32_t ul_pipe) | |||
| uint32_t UHD_Pipe_Read(uint32_t ul_pipe, uint32_t ul_size, uint8_t* data) | |||
| { | |||
| uint8_t *ptr_ep_data = 0; | |||
| uint8_t nb_byte_received = 0; | |||
| uint16_t nb_byte_received = 0; //otherwise roll over when reading pipe >256 Bytes | |||
There was a problem hiding this comment.
I feel the comment on this line will be confusing when read without the context of the other information in this pull request. If the comment is to be there, I think it could be better worded.
There was a problem hiding this comment.
You are right.
Changed comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to read longer messages (>256 bytes) from USB device from host side, the buffer rolls over overwriting the buffer.
For DUE/SAM can handle pipes with 1024 bytes, a uint16_t should be used here.
I needed this for example to be able to read 512 bytes of data from a USB-Midi device.