Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #5843

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Update repositories.txt #5843

merged 1 commit into from
Jan 29, 2025

Conversation

ben5049
Copy link
Contributor

@ben5049 ben5049 commented Jan 29, 2025

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label Jan 29, 2025
Copy link
Contributor

A problem was found with your submission https://github.com/ICRS/IC-Hack-Badge-Arduino

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @ben5049
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@ben5049
Copy link
Contributor Author

ben5049 commented Jan 29, 2025

@ArduinoBot Added a tag to the repo.

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/ICRS/IC-Hack-Badge-Arduino:

Linting library in IC-Hack-Badge-Arduino
INFO: No header file found matching library name (ICRS_101.h). Best practices are for primary header filename to match  
      library name.                                                                                                     
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name ICRS 101 contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format    
         (Rule LP015)                                                                                              
ERROR: Library name ICRS 101 is in use by a library in the Library Manager index. Each library must have a unique name  
       value. If your library is already in the index, use the "--library-manager update" flag.                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format           
       (Rule LP017)                                                                                                     
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 1 ERRORS, 3 WARNINGS

-------------------

Linting sketch in IC-Hack-Badge-Arduino/examples/Blink

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 3 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @ben5049
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@ben5049
Copy link
Contributor Author

ben5049 commented Jan 29, 2025

@ArduinoBot I have made the necessary changes.

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/ICRS/IC-Hack-Badge-Arduino:

Linting library in IC-Hack-Badge-Arduino
INFO: No header file found matching library name (IC_Hack_Badge.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name IC Hack Badge contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in IC-Hack-Badge-Arduino/examples/Blink

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit b9a40d5 into arduino:main Jan 29, 2025
14 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/ICRS/IC-Hack-Badge-Arduino/

github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant