Update comment #91
Update comment #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 752 776 +24
=========================================
+ Hits 752 776 +24 ☔ View full report in Codecov by Sentry. |
2bndy5
force-pushed
the
update-comment
branch
2 times, most recently
from
6364a8c
to
78a9da8
Compare
|
ping @per1234 |
| api_data = self.api_request( | ||
| request="repos/" + self.repository_name + "/issues/" + str(pr_number) + "/comments", | ||
| request=request_uri, | ||
| page_number=page_number, | ||
| ) | ||
|
|
||
| comments_data = api_data["json_data"] | ||
| for comment_data in comments_data: | ||
| # Check if the comment is a report for the PR's head SHA | ||
| if comment_data["body"].startswith(self.report_key_beginning + pr_head_sha): |
There was a problem hiding this comment.
The only improvement I can think of is prepending self.report_key_beginning with an HTML comment:
where as using
report_key_beginning = "<!-- arduino/report-size-deltas -->\n**Memory usage change @ "would better assure that this action doesn't attempt to alter some user's comment starting with **Memory usage change @ .
If no comment exists, then simply post a new comment. If more than 1 comment found, then delete all but last one and update the last one.
distutils has been deprecated for years; use shutil instead add unit test for `get_previous_comment()`
defaults to false for old behavior
update tests accordingly replaces `get_previous_comment()` which was almost identical to `report_exists()`
update poetry lock file
2bndy5
force-pushed
the
update-comment
branch
from
83e1dc3
to
6624ff5
Compare
|
I've been keeping my fork in sync with upstream. I've also been using these changes for all nRF24 org repos (since I opened this PR), and I haven't seen any unexpected behavior so far. Not sure what I need to do to get this reviewed (by admins). It's been idling for over half a year. This repo hasn't been getting much attention lately 😞 . |
resolves #90
Goals
What does it do?
update-commentthat defaults tofalse(for current behavior)update-commentis set totrue, the first report comment found is updated. Furthermore, if other report comments are found in the same thread, they will be deleted.Other changes
I don't have python 3.11 installed on my system any more, so I adjusted some things to work with python 3.11+ (specifically 3.11 & 3.12).
I also prefer to use a local venv for developing on python-based projects. So, I had to add some typical names used for a local venv located at repo root to
.gitignore,.flake8, and.prettierignore.I have made sure that all unit tests still pass and added one unit test for the new functionality.