Re-ordered includes in the main configure/RELEASE #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you include this justification
in your commit message? Beyond that, looks good to me. |
ADGenICam is defined after "-include" directives, this would require modifying configure/RELEASE in case of using a site-specific RELEASE.local. Also, added top-level *.local to .gitignore.
AbdallaDalleh
force-pushed
the
master
branch
from
7757794 to
94e6def
Compare
Contributor
Author
|
Thanks for the update. I have amended the commit message on my fork, let me know if it is visible for you. |
Member
|
LGTM! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADGenICam is defined after "-include" directives, this would
require modifying configure/RELEASE in case of using a site-specific
RELEASE.local. Also, added top-level *.local to .gitignore.