Open
Conversation
We observed some non-deterministic crashes in the streamTask when using the Stream2 interface. We were able to capture a core dump, and it showed that the issue was in accessing 'mImageMsg->data.len'. This access happened before checking the message type, which meant that for 'STREAM2_MSG_END' messages, it would trigger undefined behavior by accessing outside of the space allocated for s2msg. The fixed code only accesses the message through the mImageMsg pointer when it is of type 'STREAM2_MSG_IMAGE', and adds an additional sanity-check for any unexpected message types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed some non-deterministic crashes in the streamTask when using the Stream2 interface. We were able to capture a core dump, and it showed that the issue was in accessing 'mImageMsg->data.len'. This access happened before checking the message type, which meant that for 'STREAM2_MSG_END' messages, it would trigger undefined behavior by accessing outside of the space allocated for s2msg.
The fixed code only accesses the message through the mImageMsg pointer when it is of type 'STREAM2_MSG_IMAGE', and adds an additional sanity-check for any unexpected message types.
haven't been able to test this in the IOC proper, will do so tomorrow!