feature/ADH-5180 send create rule form by hot keys shift+enter #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workNpp
requested review from
alatunov,
dbardin90,
KuzminIA,
MrHalless,
remizov-arena and
rimakan
as code owners
rimakan
reviewed
Nov 1, 2024
| @@ -47,6 +47,13 @@ const RuleCreateDialog: React.FC = () => { | |||
| dispatch(createRuleWithUpdate(ruleText)); | |||
| }; | |||
|
|
|||
| const keyPress = (e: React.KeyboardEvent<HTMLTextAreaElement>) => { | |||
There was a problem hiding this comment.
handleKeyPress is better title for the function IMO
KuzminIA
approved these changes
Nov 1, 2024
remizov-arena
approved these changes
Nov 1, 2024
rimakan
approved these changes
Nov 1, 2024
dbardin90
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/ADH-5180