ADBDEV-6359: Make signal handler test more stable #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes tests of the signal handler can fail due to a long start of gpbackup/gprestore. This can happen due to slow storage and a cold disk cache. In this case, the process can receive a signal even before the signal handler is initialized. This patch adds waiting for the first line in stdout before starting the timer before sending a signal.
KnightMurloc
force-pushed
the
ADBDEV-6359
branch
from
dae3f48
to
8ae1b88
Compare
RekGRpth
reviewed
Oct 3, 2024
RekGRpth
reviewed
Oct 3, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 4, 2024
dkovalev1
reviewed
Oct 7, 2024
dkovalev1
reviewed
Oct 7, 2024
dkovalev1
reviewed
Oct 7, 2024
dkovalev1
reviewed
Oct 7, 2024
dkovalev1
reviewed
Oct 7, 2024
dkovalev1
previously approved these changes
Oct 7, 2024
RekGRpth
reviewed
Oct 8, 2024
RekGRpth
approved these changes
Oct 8, 2024
dkovalev1
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make signal handler test more stable
Sometimes tests of the signal handler can fail due to a long start of
gpbackup/gprestore. This can happen due to slow storage and a cold disk cache.
In this case, the process can receive a signal even before the signal handler
is initialized.
This patch adds waiting for the first line in stdout before starting the timer
to sending a signal.