Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADBDEV-4198: Exclude subpartitions for given root partition in leaf-partition-data mode #38

Merged
merged 15 commits into from
Sep 22, 2023

Conversation

HustonMmmavr
Copy link

@HustonMmmavr HustonMmmavr commented Sep 4, 2023

Exclude subpartitions for given root partition in leaf-partition-data mode

gpbackup with the --leaf-partition-data and --exclude <root_partition> options
adds leaf partitions to the recovery plan, but the root partition is not
included in the schema creation script and gprestore fails with an error.

The solution is to exclude all leaf partitions for a given root partition
in leaf-partition-data mode.

The first test checks that if root partition exclusion and the
leaf-partition-data option are specified, then leaf partitions
should not be included in the restore.
The second test checks that if leaf partition exclusion and the
leaf-partition-data option are specified, then the patch does not
change the behavior: only this leaf partition is excluded from the backup.
The third test checks that if only a root partition exclusion
is specified, then the patch does not change the behavior:
the table does not include into the backup.

@HustonMmmavr HustonMmmavr marked this pull request as draft September 4, 2023 08:41
HustonMmmavr and others added 2 commits September 5, 2023 13:54
… mode

gpbackup with the --leaf-partition-data and --exclude <root_partition> options
adds leaf partitions to the recovery plan, but the root partition is not
included in the schema creation script and gprestore fails with an error.

The solution is to exclude all leaf partitions for a given root partition
in leaf-partition-data mode.
@RekGRpth RekGRpth changed the title Temporary version of fix ADBDEV-4198: Exclude subpartitions for given root partition in leaf-partition-data mode Sep 11, 2023
@RekGRpth RekGRpth marked this pull request as ready for review September 11, 2023 10:47
@RekGRpth RekGRpth requested a review from a team September 11, 2023 10:47
dnskvlnk
dnskvlnk previously approved these changes Sep 12, 2023
Copy link
Member

@RekGRpth RekGRpth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support 7X

@RekGRpth RekGRpth requested review from RekGRpth and removed request for RekGRpth September 18, 2023 09:13
@HustonMmmavr
Copy link
Author

LGTM

@Stolb27
Copy link

Stolb27 commented Sep 21, 2023

Only the 1st test failed on the build without patch. Is it expected? What do the remaining two test check?

• [FAILED] [3.335 seconds]
End to End Filtered tests Exclude subpartitions for given root partition in leaf-partition-data mode [It] runs gpbackup and gprestore with leaf-partition-data and exclude-table root partition backup flags
/home/givi/projects/gpbackup/end_to_end/filtered_test.go:439

  [FAILED] exit status 1
  In [It] at: /home/givi/projects/gpbackup/end_to_end/end_to_end_suite_test.go:309 @ 09/21/23 15:54:01.564
------------------------------
••SSS

Summarizing 1 Failure:
  [FAIL] End to End Filtered tests Exclude subpartitions for given root partition in leaf-partition-data mode [It] runs gpbackup and gprestore with leaf-partition-data and exclude-table root partition backup flags
  /home/givi/projects/gpbackup/end_to_end/end_to_end_suite_test.go:309

Ran 3 of 181 Specs in 12.878 seconds
FAIL! -- 2 Passed | 1 Failed | 3 Pending | 175 Skipped

@RekGRpth
Copy link
Member

Only the 1st test failed on the build without patch. Is it expected? What do the remaining two test check?

Yes, according to the specification, the other two cases should not have broken.

@RekGRpth
Copy link
Member

Only the 1st test failed on the build without patch. Is it expected? What do the remaining two test check?

Yes, according to the specification, the other two cases should not have broken.

I added a description of the tests to the description of the pull request.

@Stolb27 Stolb27 merged commit 1be2727 into master Sep 22, 2023
1 of 4 checks passed
@Stolb27 Stolb27 deleted the ADBDEV-4198 branch September 22, 2023 09:10
Stolb27 added a commit that referenced this pull request Dec 7, 2023
…n leaf-partition-data mode (#38)"

to solve conflicts with 7833212

This reverts commit 1be2727.
Stolb27 added a commit that referenced this pull request Feb 9, 2024
…n leaf-partition-data mode (#38)"

to solve conflicts with 7833212

This reverts commit 1be2727.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants