-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-4198: Exclude subpartitions for given root partition in leaf-partition-data mode #38
Conversation
df14050
to
9352996
Compare
… mode gpbackup with the --leaf-partition-data and --exclude <root_partition> options adds leaf partitions to the recovery plan, but the root partition is not included in the schema creation script and gprestore fails with an error. The solution is to exclude all leaf partitions for a given root partition in leaf-partition-data mode.
af04fdd
to
f61d917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add support 7X
LGTM |
Only the 1st test failed on the build without patch. Is it expected? What do the remaining two test check?
|
Yes, according to the specification, the other two cases should not have broken. |
I added a description of the tests to the description of the pull request. |
Exclude subpartitions for given root partition in leaf-partition-data mode
gpbackup with the --leaf-partition-data and --exclude <root_partition> options
adds leaf partitions to the recovery plan, but the root partition is not
included in the schema creation script and gprestore fails with an error.
The solution is to exclude all leaf partitions for a given root partition
in leaf-partition-data mode.
The first test checks that if root partition exclusion and the
leaf-partition-data option are specified, then leaf partitions
should not be included in the restore.
The second test checks that if leaf partition exclusion and the
leaf-partition-data option are specified, then the patch does not
change the behavior: only this leaf partition is excluded from the backup.
The third test checks that if only a root partition exclusion
is specified, then the patch does not change the behavior:
the table does not include into the backup.