Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADBDEV-4377: Fix backup statistics for leaf partitions #42

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

RekGRpth
Copy link
Member

@RekGRpth RekGRpth commented Sep 27, 2023

Fix backup statistics for leaf partitions

gpbackup does not backup statistics for leaf partitions with leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

@RekGRpth RekGRpth changed the title ADBDEV-4377: pgbackup does not backup statistics for leaf partitions ADBDEV-4377: pgbackup does not backup statistics for leaf partitions with leaf-partition-data option Sep 27, 2023
@RekGRpth RekGRpth changed the title ADBDEV-4377: pgbackup does not backup statistics for leaf partitions with leaf-partition-data option ADBDEV-4377: gpbackup does not backup statistics for leaf partitions with leaf-partition-data option Sep 27, 2023
@RekGRpth RekGRpth changed the base branch from master to ADBDEV-4376 September 27, 2023 09:59
@RekGRpth RekGRpth changed the base branch from ADBDEV-4376 to master September 27, 2023 10:10
@RekGRpth RekGRpth marked this pull request as ready for review September 27, 2023 11:17
@RekGRpth RekGRpth changed the base branch from master to ADBDEV-4376 September 27, 2023 11:17
Copy link

@red1452 red1452 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change branch ADBDEV-4376 to master.

end_to_end/end_to_end_suite_test.go Show resolved Hide resolved
backup/wrappers.go Outdated Show resolved Hide resolved
@RekGRpth RekGRpth changed the base branch from ADBDEV-4376 to master October 26, 2023 16:04
@RekGRpth
Copy link
Member Author

You should change branch ADBDEV-4376 to master.

Done

@red1452
Copy link

red1452 commented Oct 27, 2023

I think, you should rewrite the head of commit message. Head should answer the question: "what had been done?". For example: "Fix something at somewhere".

@RekGRpth RekGRpth changed the title ADBDEV-4377: gpbackup does not backup statistics for leaf partitions with leaf-partition-data option ADBDEV-4377: Fix backup statistics for leaf partitions Oct 27, 2023
@RekGRpth
Copy link
Member Author

you should rewrite the head of commit message

I changed the name and content of the PR. Will this work for a commit? If so, can I force push changes?

@red1452
Copy link

red1452 commented Oct 27, 2023

I changed the name and content of the PR. Will this work for a commit? If so, can I force push changes?

You can add empty commit with new commit message without force-push (git commit --allow-empty).

gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.
@andr-sokolov andr-sokolov merged commit 0ce7382 into master Nov 27, 2023
2 of 3 checks passed
Stolb27 added a commit that referenced this pull request Dec 7, 2023
to solve conflicts with 7833212

This reverts commit 0ce7382.
Stolb27 pushed a commit that referenced this pull request Dec 7, 2023
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
RekGRpth added a commit that referenced this pull request Dec 28, 2023
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
Stolb27 added a commit that referenced this pull request Feb 9, 2024
to solve conflicts with 7833212

This reverts commit 0ce7382.
Stolb27 pushed a commit that referenced this pull request Feb 9, 2024
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
(cherry picked from commit 6b5fe21)
RekGRpth added a commit that referenced this pull request Jul 16, 2024
This reverts commit 2de6423 to solve conflicts
with 12bca9e.
RekGRpth added a commit that referenced this pull request Jul 17, 2024
This reverts commit 2de6423 to solve conflicts with 12bca9e.
RekGRpth added a commit that referenced this pull request Jul 19, 2024
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
(cherry picked from commit 6b5fe21)
(cherry picked from commit 2de6423)
RekGRpth added a commit that referenced this pull request Jul 23, 2024
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
(cherry picked from commit 6b5fe21)
(cherry picked from commit 2de6423)
RekGRpth added a commit that referenced this pull request Jul 26, 2024
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
(cherry picked from commit 6b5fe21)
(cherry picked from commit 2de6423)
RekGRpth added a commit that referenced this pull request Jul 26, 2024
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
(cherry picked from commit 6b5fe21)
(cherry picked from commit 2de6423)
RekGRpth added a commit that referenced this pull request Aug 1, 2024
RekGRpth added a commit that referenced this pull request Aug 1, 2024
gpbackup does not backup statistics for leaf partitions with
leaf-partition-data option

This patch solves the problem by backuping statistics for all specified
tables, including leaf partitions, and not just root partitions.

The test for this patch is based on the test for the 85384fa.
And, as stated in that patch, it removes the unnecessary
condition when comparing the number of statistics.

Cherry-picked-from: 0ce7382
(cherry picked from commit 6b5fe21)
(cherry picked from commit 2de6423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants